-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving issues #1, #2, and #4 #3
base: master
Are you sure you want to change the base?
Conversation
Hey man, it would be great if you could squash your commits to not add unnecessary commits. It seems to me that the two commits for changing the Example can be squashed into one. As for the other two commits, the content looks good, but if you could add the text |
I don't normally do things like squashing commits so I'll have to google around for that, but I can try to do that right now. |
Not a problem, let me know if I can help, it's good practice to learn early so you know for later :) |
+ forgot to do this earlier
I also forgot to update the |
But I've haven't used github to contribute to projects that much, so I don't know much of the etiquette related to it. I just kind of made a commit when I added something. |
I totally understand, a lot of projects don't really mind how they do commits, but I enjoy keeping a clean commit tree, and I also enjoy seeing people learn git more in-depth than just adding, committing, and pushing, so I hope you have added this skill to your repertoire. @Sk1er will still have to review this PR, but the commit structure looks great to me. |
I'm lowkey kinda waiting on this to be approved so I can make a pull request for this lmao (it says 4 commits ahead, but it's only 1 commit ahead of this pull request) |
Some quick changes to resolve the issues #1, #2 and #4 that I created earlier.